[LTP] [PATCH] syscalls/creat/creat09: fix error check of create syscall

[Li Wang]

Hi,

On Thu, Dec 17, 2015 at 1:54 PM, TAKAHASHI Tetsuya <
takahashi.tetsuya.cis@canon-is.co.jp> wrote:

> Hello.
>
> I think that a create syscall check of syscalls/creat/creat09 is wrong.
>
> When create syscall cannot make a file, the test result becomes PASS.
> In this case, the test result becomes FAIL is right.
>

yes, I agree with u.


>
>
> diff -uprN a/testcases/kernel/syscalls/creat/creat09.c
> b/testcases/kernel/syscalls/creat/creat09.c
> --- a/testcases/kernel/syscalls/creat/creat09.c 2015-12-03
> 05:53:41.000000000 +0900
> +++ b/testcases/kernel/syscalls/creat/creat09.c 2015-12-06
> 01:48:34.757125367 +0900
> @@ -139,9 +139,13 @@ int main(int ac, char **av)
>
>                 TEST(creat(fname, 0700));
>
> -               if (TEST_RETURN == -1) {
> +               if (TEST_RETURN != -1) {
>                         tst_resm(TPASS, "creat(%s, 0700) returned %ld",
>                                  fname, TEST_RETURN);
> +               } else {
> +                       tst_resm(TFAIL | TTERRNO, "creat(%s, 0700) FAILED",
> +                                fname);
> +                       continue;


why using continue here?   it will skip some cleanup codes in the following.

so, how about make something like:
------------$ git diff
diff --git a/testcases/kernel/syscalls/creat/creat09.c
b/testcases/kernel/syscalls/creat/creat09.c
index e52ad34..f680a78 100644
--- a/testcases/kernel/syscalls/creat/creat09.c
+++ b/testcases/kernel/syscalls/creat/creat09.c
@@ -139,10 +139,12 @@ int main(int ac, char **av)

                TEST(creat(fname, 0700));

-               if (TEST_RETURN == -1) {
+               if (TEST_RETURN != -1)
                        tst_resm(TPASS, "creat(%s, 0700) returned %ld",
                                 fname, TEST_RETURN);
-               }
+               else
+                       tst_resm(TFAIL | TTERRNO, "creat(%s, 0700) FAILED",
+                               fname);


-- 
Regards,
Li Wang
Email: liwang@redhat.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20151217/7764e58c/attachment.html>