[LTP] [PATCH] commands/mkfs/mkfs01.sh: fix mkfs testcase

Lei Li rocklee_104@outlook.com
Fri Nov 13 05:42:06 CET 2015



On 2015/11/12 20:58, Cyril Hrubis wrote:
> Hi!
>> diff --git a/testcases/commands/mkfs/mkfs01.sh
>> b/testcases/commands/mkfs/mkfs01.sh
>> index 5b62df4..31e3e15 100755
>> --- a/testcases/commands/mkfs/mkfs01.sh
>> +++ b/testcases/commands/mkfs/mkfs01.sh
>> @@ -93,7 +93,7 @@ mkfs_verify_type()
>>    		blkid $2 -t TYPE="ext2" >/dev/null
>>    	else
>>    		if [ "$1" = "msdos" ]; then
>> -			blkid $2 -t SEC_TYPE="$1" >/dev/null
>> +			blkid $2 -t TYPE="vfat" >/dev/null
>
> Hmm I can see the SEC_TYPE set to msdos for both mkfs.msdos and
> mkfs.vfat.
>
> But indeed both mkfs.vfat and mkfs.msdos are symlinks to mkfs.fat and
> seems to produce the same result.
>
> I would have applied the patch but it does not apply (looks like
> whitespaces were mangled somehow). Can you please make sure that your
> email client is set up in a way that does not mangle patches and then
> resend the patch?
>
Sorry, my bad, I will resend this patch later.

-- 
Rock Lee
rocklee_104@outlook.com


More information about the Ltp mailing list