[LTP] [PATCH v2 1/2] kernel/io/disktest: cleanup upon failure occurs

Cyril Hrubis chrubis@suse.cz
Tue Nov 24 15:08:53 CET 2015


Hi!
>  		pMsg(ERR, args, "%s: Error = %u\n", args->device,
>  		     GETLASTERROR());
> +		FREE(buff);
>  		return (-1);
>  	}
>  
>  	TargetLBA = Seek(fd, args->start_lba * BLK_SIZE);
>  	if (TargetLBA != (args->start_lba * (OFF_T) BLK_SIZE)) {
>  		pMsg(ERR, args, "Could not seek to start position.\n");
> +		FREE(buf);
                     ^
		     Should be buff

The code does not even compile after the change, can you please compile
test your change to avoid typos like this one?

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the Ltp mailing list