[LTP] [PATCH v2 2/2] network/nfs05: rewrite the test, make use of new library

Alexey Kodanev alexey.kodanev@oracle.com
Tue Aug 16 18:01:46 CEST 2016


Hi,
On 08/16/2016 06:34 PM, Cyril Hrubis wrote:
> Hi!
>>   tst_resm TINFO "start nfs05_make_tree -d $DIR_NUM -f $FILE_NUM -t $THREAD_NUM"
>> -ROD nfs05_make_tree -d $DIR_NUM -f $FILE_NUM -t $THREAD_NUM
>> +TMPDIR=$(pwd) nfs05_make_tree -d $DIR_NUM -f $FILE_NUM -t $THREAD_NUM
> Hmm, the tst_tmpdir is created and mounted in the nfs_setup right?
>
> Why can't we just let the nfs05_make_tree work with current
> directory and omit the needs_tmpdir = 1 from it's source? It's not like
> the nfs05_make_tree binary is supposed to be executed directly, so it's
> OK if it starts to create files in PWD.

You are right, it's not used other than inside nfs05 script so the flag 
can be
safely removed along with "TMPDIR=$(pwd)".

Thanks,
Alexey


More information about the ltp mailing list