[LTP] [PATCH V2 18/32] guard mallocopt() with __GLIBC__

Cyril Hrubis chrubis@suse.cz
Tue Feb 2 17:15:33 CET 2016


Hi!
> ---
>  utils/benchmark/ebizzy-0.3/ebizzy.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/utils/benchmark/ebizzy-0.3/ebizzy.c b/utils/benchmark/ebizzy-0.3/ebizzy.c
> index 5bb8eff..934d951 100644
> --- a/utils/benchmark/ebizzy-0.3/ebizzy.c
> +++ b/utils/benchmark/ebizzy-0.3/ebizzy.c
> @@ -215,10 +215,10 @@ static void read_options(int argc, char *argv[])
>  			"\"never mmap\" option specified\n");
>  		usage();
>  	}
> -
> +#ifdef __GLIBC__
>  	if (never_mmap)
>  		mallopt(M_MMAP_MAX, 0);
> -
> +#endif

Silently ignoring user switches is not a good practice. You should at
least print warning that the functionality is not supported.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the Ltp mailing list