[LTP] [PATCH] syscalls/getpriority01: exclude default priority check for PRIO_USER.

Guangwen Feng fenggw-fnst@cn.fujitsu.com
Tue Nov 22 10:34:33 CET 2016


Hi!

Thanks for your review.

On 11/22/2016 04:56 PM, Cyril Hrubis wrote:
> Hi!
>> The current user priority is various when testing,
>> we should not check it as default value.
> 
> What system does this happen on? It should probably be mentioned in the
> commit message.

It happens on Fedora20, RHEL5.11GA, RHEL6.8GA, RNEL7.3GA, testing returns
-20 and -11 for PRIO_USER as root and nobody respectively.

> 
> And we should probably as well just revert the change I've did and check
> only that errno wasn't set since the value may be set even to -1.

I think so, checking "TEST_ERRNO != 0" is adequate for the case.

Best Regards,
Guangwen Feng




More information about the ltp mailing list