[LTP] [PATCH v4 1/3] lib: Add personality fallback and SAFE macro

Richard Palethorpe rpalethorpe@suse.de
Thu Aug 10 09:24:23 CEST 2017


Hello Metan,

Cyril Hrubis writes:

> Hi!
>> +#ifndef PERSONALITY_H
>> +#define PERSONALITY_H
>> +
>> +#include <sys/personality.h>
>> +
>> +#if !(HAVE_DECL_UNAME26 == 1 || defined(UNAME26))
>              ^
> 	 Where is this macro from, I cannot see it anywhere.
>
> Have you forgotten git add on configure.ac or something?

Sorry, I am not sure what has happened there.

>
> And I doubt that we need anything else than:
>
> #ifndef UNAME26
> # define UNAME26 0x0020000
> #endif
>
> here...

It is defined as an enum in glibc, but as a macro in musl. I guess it
doesn't matter if macro covers the enum though, except maybe that some
debugging symbol is lost.

-- 
Thank you,
Richard.


More information about the ltp mailing list