[LTP] [PATCH v3] syscalls/fcntl36: add tests for OFD locks

Cyril Hrubis chrubis@suse.cz
Wed Aug 23 10:40:20 CEST 2017


Hi!
> > > +	if (tst_fill_file(fname, 1, write_size, thread_cnt)) {
> > > +		tst_brk(TBROK, "Failed to create tst file");
> > > +	}
> > 
> > No need for the curly braces around single line statement here.
> 
> I thought it's safer for a macro. Now it's one line function in
> the macro, not hurting to remove the braces.

Even macros that have several lines are safe in LTP since we use the
do { ... } while (0) idiom.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list