[LTP] [RFC PATCH 1/2] network/ipsec: Add trap to INT and require root
Petr Vorel
pvorel@suse.cz
Mon Dec 11 15:36:22 CET 2017
Hi!
> > > > +trap "tst_brkm TBROK 'test interrupted'" INT
> > > Could we add it to test_net.sh?
> > Sure. I was even thinking about giving it into test_net.sh and test.sh (i.e. making it the
> > default settings), but that's maybe too aggressive.
> Unless we find a test that traps INT in order to attempt to cleanup
> doing tst_brkm on INT in test library is IMHO okay.
$ git grep -i trap.*INT $(git grep -l -e '\. tst_test.sh' -e '\. test.sh')
testcases/kernel/device-drivers/locking/lock_torture.sh:trap cleanup INT
testcases/kernel/device-drivers/rcu/rcu_torture.sh:trap cleanup INT
testcases/kernel/tracing/ftrace_test/ftrace_lib.sh: trap clean_up_exit INT
But do we need to care? Test will just silently redefine settings from library.
They are all using test.sh, so we can add
trap "tst_brk TBROK 'test interrupted'" INT
to tst_test.sh.
Kind regards,
Petr
More information about the ltp
mailing list