[LTP] [PATCH 2/2] ltp-aiodio/dio_sparse: Fix usleep in read_sparse()

[Guangwen Feng]

Hi Cyril,

Thanks for your review.

On 01/24/2017 09:43 PM, Cyril Hrubis wrote:
> Hi!
>> diff --git a/testcases/kernel/io/ltp-aiodio/common_sparse.h b/testcases/kernel/io/ltp-aiodio/common_sparse.h
>> index f7f4ef4..a7f5035 100644
>> --- a/testcases/kernel/io/ltp-aiodio/common_sparse.h
>> +++ b/testcases/kernel/io/ltp-aiodio/common_sparse.h
>> @@ -123,7 +123,7 @@ static void read_sparse(char *filename, int filesize)
>>  			fprintf(stderr, "Child %i waits for '%s' to appear\n",
>>  			        getpid(), filename);
>>  
>> -		usleep(100000);
>> +		usleep(10);
> 
> Isn't 10us too small? Also we really should increase the number of the
> loop iterations if we reduce the sleep as much.
> 

Most of the time child works well by usleep(100), but there is still
a small chance that it misses the test on my system...

OK, I will also increase the loop number and send a V2.
Thanks.

Best Regards,
Guangwen Feng

>>  	}
>>  
>>  	if (fd == -1) {
>> -- 
>> 1.8.4.2
>>
>>
>>
>>
>> -- 
>> Mailing list info: https://lists.linux.it/listinfo/ltp
>