[LTP] [RFC PATCH v6 00/11] Simplify network setup + fix some network stress tests

Alexey Kodanev alexey.kodanev@oracle.com
Wed Jun 7 11:48:26 CEST 2017


On 06/06/2017 04:23 PM, Petr Vorel wrote:
> Hi Alexey,
>
> thanks for your input.
>
>> tst_rhost_run() with "two hosts" setup is using just RHOST
>> variable (management link) for rsh/ssh, it can have the same
>> route as IP_RHOST or better something different that won't be
>> affected by the tests.
> Ok, for ssh/rsh, if prefix isn't defined in IPV{4,6}_LHOST I'll read it with
> tst_rhost_run, using RHOST. That means to have separate binary for rtnetlink code.
>
> I'll move default prefix values (24 and 64) from tst_net_vars.c to test_net.sh, these
> values will be used as default for netns and used for rsh/ssh only if prefixes aren't
> specified in IPV{4,6}_LHOST and nothing found with rtnetlink.
> I also want to find via rtnetlink getting lhost and rhost iface. I wonder whether founded
> ifaces (rhost and lhost) should be also added into {L,R}HOST_IFACES even if variables are
> already specified by user and don't contain them.

It's better to leave interfaces unchanged if a user has already defined
them.
The rest sounds good to me.

Thanks,
Alexey



More information about the ltp mailing list