[LTP] [PATCH] min_free_kbytes : Check panic_on_oom before running

Cyril Hrubis chrubis@suse.cz
Thu Mar 2 17:10:57 CET 2017


Hi!
> diff --git a/testcases/kernel/mem/tunable/min_free_kbytes.c b/testcases/kernel/mem/tunable/min_free_kbytes.c
> index cb00f40..8b6dc1c 100644
> --- a/testcases/kernel/mem/tunable/min_free_kbytes.c
> +++ b/testcases/kernel/mem/tunable/min_free_kbytes.c
> @@ -71,6 +71,9 @@ int main(int argc, char *argv[])
>  
>  	tst_parse_opts(argc, argv, NULL, NULL);
>  
> +	if (get_sys_tune("panic_on_oom"))
> +		tst_brkm(TCONF, NULL,
> +			"panic_on_oom is set, disable it to run these testcases");

This check should be put into the test setup() and LKML coding style
prefers curly braces around multiline statemets like this.

Otherwise it looks fine.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list