[LTP] Access02 and use of system() library function

[Cyril Hrubis]

Hi!
> > What LTP version is this? The access02 test was rewritten some time ago and
> > there is no test_file3 since commit:
> >
> > commit adb3e23d9de5f8ff54d2395112f79f25c36cf598
> > Author: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
> > Date:   Wed Jul 20 18:44:39 2016 +0800
> >
> >     syscalls/access02: reconstruct and convert to new API
> >
> > Which is included in last to stable releases....
> >
> You're right, i am using an old version of LTP (20160126).
>
> It does not change my remark anyway, newer test does X_OK test using
> system() library function. The return value is checked against 0 for
> success, whereas I suggest that it should check against any positive
> value, or even against any value but -1.

Hmm, we can always write a shebang to the file then the file should be
recognized by shell, right?

Does this fixes the issue:

diff --git a/testcases/kernel/syscalls/access/access02.c b/testcases/kernel/syscalls/access/access02.c
index 779e81a..86e0342 100644
--- a/testcases/kernel/syscalls/access/access02.c
+++ b/testcases/kernel/syscalls/access/access02.c
@@ -187,6 +187,7 @@ static void setup(void)
 	SAFE_TOUCH(FNAME_R, 0444, NULL);
 	SAFE_TOUCH(FNAME_W, 0222, NULL);
 	SAFE_TOUCH(FNAME_X, 0555, NULL);
+	SAFE_FILE_PRINTF(FNAME_X, "#!/bin/sh\n");
 
 	SAFE_SYMLINK(FNAME_F, SNAME_F);
 	SAFE_SYMLINK(FNAME_R, SNAME_R);

-- 
Cyril Hrubis
chrubis@suse.cz