[LTP] [RFC] [PATCH] syscalls/madvise09: Fix for disabled swap accounting

Cyril Hrubis chrubis@suse.cz
Wed May 3 10:18:32 CEST 2017


Hi!
> > The test had to be fixed for systems with swap accounting disabled.
> > 
> > First there are no "memsw" prefixed tuning knobs in memcg directories if
> > swap accounting is disabled.
> > 
> > Then we had to limit the hungry child since otherwise it will be killed
> > only after all system swap was filled. Hence we exit the memory hungry
> > child once the process fills 100MB of swap. That seems to be enough to
> > put the cgroup into memory pressure while it limits the test runtime to
> > a few seconds.
> 
> Looks reasonable to me, only 2 alternatives I can think of is turning
> off swap for duration of test, or exit with TCONF if swap accounting
> is disabled.

We cannot turn off the swap since MADV_FREE does not work without
it. So it's either TCONF or limiting the swap usage in the hungry child
as this patch does...

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list