[LTP] [PATCH 1/1] utils/compat_16.mk: Further cleanup of unused sections and variables

Petr Vorel pvorel@suse.cz
Tue Apr 10 08:19:29 CEST 2018


Hi Yang,

> Hi Petr

> -%_16.o: %.c $(COMPAT_16_H)

> This make dependency for recompiling _16.o when header changes.

> $(MAKE_TARGETS_OBJS_WO_COMPAT_16): $(COMPAT_16_H)
> .INTERMEDIATE: $(MAKE_TARGETS_OBJS_WO_COMPAT_16)

> This make dependency for recompiling .o when header changes.

> I think you may miss something.

> This patch will reappear the problem that has been fixed since commit
> 631d16671d(syscalls/utils/compat_16.mk: fix build dependencies).
> If we touch/modify the compat_tst_16.h/compat_16.h file and excute "make"
> in any of syscalls directories which includes compat_16.mk, nothing will
> happen.

Thank you for explaining and sorry for wrong patch.
Before I touch wrong file, that's why it didn't work the obvious way you described.

I still thing that HAS_COMPAT_16 variable is unused and not needed.


Kind regards,
Petr

> Best Regards
> Yang Xu


More information about the ltp mailing list