[LTP] [PATCH 2/2] network/in6_02: Don't use default value for LHOST_IFACES

Petr Vorel pvorel@suse.cz
Wed Apr 18 16:13:56 CEST 2018


Hi Alexey,

> On 04/17/2018 03:42 PM, Petr Vorel wrote:
> > in6_02 can be test without help of network.sh. In that case LHOST_IFACES
> > is not defined and "eth0" is used as default value. This can cause
> > failures.

> I think the fix should be before the conversion to the new API, otherwise
> it unnecessary depends on it.
Agree, I'll fix it.

...
> >  	for (i = 0; i < ARRAY_SIZE(test_case); ++i) {
> > +		if (test_case[i].name == NULL)
> > +			continue;

> What about using TCONF if it skips the test-case because
> LHOST_IFACE is not defined?
I wanted to keep at least testing of if_nametoindex("lo").
Would be overkill in case of TCONF to create in6_02.sh which would just load tst_net.sh?
I don't like the fact, that network C tests depend on being run via network.sh (unlike
shell network tests).

> Thanks,
> Alexey


Kind regards,
Petr


More information about the ltp mailing list