[LTP] [PATCH] add ip6tables test case

Sun Lianwen sunlw.fnst@cn.fujitsu.com
Mon Apr 23 10:08:06 CEST 2018


Hi Petr

On 04/23/2018 03:52 PM, Petr Vorel wrote:
> Hi Lianwen Sun,
> 
>> Add ip6tables test case base on case of iptables
> 
>> Signed-off-by: sunlw <sunlw.fnst@cn.fujitsu.com>
>> ---
>>  runtest/net.tcp_cmds                          |   1 +
>>  testcases/network/iptables/Makefile           |   2 +-
>>  testcases/network/iptables/ip6tables_tests.sh | 386 ++++++++++++++++++
>>  3 files changed, 388 insertions(+), 1 deletion(-)
>>  create mode 100755 testcases/network/iptables/ip6tables_tests.sh
> 
> Thanks for your patch. IMHO instead of adding ip6tables_tests.sh, file iptables_tests.sh
> could be easily extended to support both IPv4/IPv6, using TST_IPV6 to distinguish. Most of
> other network tests is using that. This reduces duplicity of code and helps further
> changes (e.g. migration to new shell API).
>
Thanks your advise, I will try to rewrite this patch.

Best Wishes,
Lianwen Sun





More information about the ltp mailing list