[LTP] [PATCH v2] Add read_all file systems test

Richard Palethorpe rpalethorpe@suse.de
Tue Feb 13 16:33:11 CET 2018


Hello,

Cyril Hrubis writes:

> Hi!
>> >> +	queue_destroy(q, 1);
>> >> +	fflush(stdout);
>> >
>> > What are trying to flush here? The tst_res() messages are printed
>> > into the stderr btw.
>>
>> I found that the pass message was being written after some of the
>> childrens' information messages. Calling fflush on stdout prevents that
>> from happening even though it is the wrong fd...
>
> You mean the tst_res(TPASS, ...) called after the tst_reap_children() ?
>
> That is really strange since at that time the processes had called
> exit() already and the buffers should have been flushed at that point.
> I.e. if we haven't flushed it in the worker_run() the exit() should take
> care of that, which is guaranteed to run before we return from the
> tst_reap_children().

It only happens on older products, so it could be removed if you are not
concerned about that? I'm not sure if investigating it further would be
useful.

Also I found a bug when pushing to a full queue, so I need to do another
patch revision anyway.

--
Thank you,
Richard.


More information about the ltp mailing list