[LTP] [PATCH] interface/if4-addr-change : NS_TIMES is not set value

Petr Vorel pvorel@suse.cz
Mon Feb 26 11:57:20 CET 2018


Hi Lianwen,

> $NS_TIMES is not set value which lead  run if4-addr-chage to failure.
> failure message as below:
> --------------------------------------------------------------------------------------------
> /opt/ltp/testcases/bin/if4-addr-change: line 24: / 20: syntax error: operand
> expected (error token is "/ 20")
> --------------------------------------------------------------------------------------------
> Signed-off-by:  Lianwen Sun  <sunlw.fnst@cn.fujitsu.com>
> ---
>  testcases/network/stress/interface/if4-addr-change | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

> diff --git a/testcases/network/stress/interface/if4-addr-change
> b/testcases/network/stress/interface/if4-addr-change
> index a665b85ff..4eaabd70c 100644
> --- a/testcases/network/stress/interface/if4-addr-change
> +++ b/testcases/network/stress/interface/if4-addr-change
> @@ -21,12 +21,12 @@ TST_TOTAL=1
>  TCID=if4-addr-change
>  TST_CLEANUP="do_cleanup"

> +. test_net.sh
> +
>  CHECK_INTERVAL=${CHECK_INTERVAL:-$(($NS_TIMES / 20))}
>  # Maximum host portion of the IPv4 address on the local host
>  LHOST_IPV4_HOST_MAX="254"

> -. test_net.sh
> -
>  do_cleanup()
>  {
>         tst_restore_ipaddr

Thanks!
I cleanup commit message a bit and pushed as:
bf212807f ("net/if4-addr-change: Load test_net.sh before using NS_TIMES")

Kind regards,
Petr


More information about the ltp mailing list