[LTP] [PATCH v4 2/2] syscalls/migrate_pages03.c: Add new regression test

Cyril Hrubis chrubis@suse.cz
Thu Jan 4 16:30:45 CET 2018


Hi!
> +#include <errno.h>
> +#include <unistd.h>
> +#include <stdlib.h>
> +#if HAVE_NUMA_H
> +#include <numa.h>
> +#endif
> +#if HAVE_NUMAIF_H
> +#include <numaif.h>
> +#endif
> +
> +#include "config.h"

One small nit, the HAVE_NUMA* macros are defined in config.h so they are
defined only after the config.h header is included. I wonder if these
haders are needed to be included here at all, because they were not
included at all.

Also it's customary to use #ifdef instead of #if for autoconf macros.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list