Hi! > # if requested fs not supported default it to ext2 > - which mkfs.$fs > /dev/null 2>&1 || fs=ext2 > + tst_supported_fs $fs > /dev/null 2>&1 > + [ $? -eq 0 ] && fs=ext2 Should just: tst_supported_fs $fs || fs=ext2 suffice here? (assuming that tst_supported_fs returns 0 on success) -- Cyril Hrubis chrubis@suse.cz