[LTP] [PATCH v2 1/1] tst_test.sh: Add test cmd helper tst_test_cmds()

Petr Vorel pvorel@suse.cz
Tue Jul 24 17:19:56 CEST 2018


Hi Cyril,

> Hi!
> > > Hmm looking at this after a while I would expect the tst_test_cmds() to
> > > exit the test while tst_check_cmds() to return a value, the question is
> > > if this is worth of the work of renaming the current uses...
> > Indeed, names would be better to be reversed. It's up to you.
> > If you want, I'll first rename tst_check_cmds() to tst_test_cmds()
> > and then add this new one as tst_check_cmds().

> If it's easy enough, let's do that, otherwise I would keep it as it is.
merged rename, updated version of now called tst_check_cmds() and it's initial
usage in IMA.
+ Updated wiki (+ updating changes to wiki from commit e11b7c036 tst_timer: Add
tst_timer_expired_ms()

Thanks for your time to review!


Kind regards,
Petr


More information about the ltp mailing list