[LTP] [PATCH] direct_io: diotest4: fix mips MAP_SHARED/MAP_FIXED mmap

Jan Stancek jstancek@redhat.com
Thu Jul 4 16:51:54 CEST 2019



----- Original Message -----
> Hi!
> > > > diff --git a/include/lapi/mmap.h b/include/lapi/mmap.h
> > > > index 18547c0d47ed..98b6ade1e2ab 100644
> > > > --- a/include/lapi/mmap.h
> > > > +++ b/include/lapi/mmap.h
> > > > @@ -19,6 +19,8 @@
> > > >  #ifndef LAPI_MMAP_H__
> > > >  #define LAPI_MMAP_H__
> > > >  
> > > > +#include "config.h"
> > > > +
> > > >  #ifndef MAP_HUGETLB
> > > >  # define MAP_HUGETLB 0x40000
> > > >  #endif
> > > 
> > > Huh, this looks completely unrelevant to the patch itself, or do I miss
> > > something?
> > 
> > This fixes the original problem of bad alignment.
> > Hunk below improves on it by removing MAP_FIXED altogether.
> 
> Ah, that is needed for the HAVE_SYS_SHM_H.
> 
> > I could split it into 2 patches, if you prefer that.
> 
> Yes please, both are acked, so just push them.

Pushed as 2 patches.


More information about the ltp mailing list