[LTP] [PATCH v3] syscalls/mbind0{2,3,4}: Add basic mbind tests

Li Wang liwang@redhat.com
Wed Jul 24 11:27:04 CEST 2019


Hi Cyril,

On Tue, Jul 23, 2019 at 7:59 PM Cyril Hrubis <chrubis@suse.cz> wrote:

> +#include "tst_test.h"
> +#include "tst_numa.h"
> +
> +#ifdef HAVE_NUMA_H

HAVE_NUMA_V2 is needed here, to avoid hitting cross-compilation failures.
    https://travis-ci.com/wangli5665/ltp/builds/120315507

In case you missed some comments from Petr, plz see:
    http://lists.linux.it/pipermail/ltp/2019-June/012226.html
    http://lists.linux.it/pipermail/ltp/2019-June/012227.html

> +
> +       TEST(mbind(ptr, size, mode, bm->maskp, bm->size + 1, MPOL_MF_STRICT));
> +

Maybe we also need to move the tst_numa_unmap/numa_free_nodemask to
here, in case of the mbind02 hit fail and return early.

Besides these tiny issues, patch v3 looks good to me.

--
Regards,
Li Wang


More information about the ltp mailing list