[LTP] [PATCH] syscalls/statx01: loosen the stx_blocks check

Cyril Hrubis chrubis@suse.cz
Wed Jul 24 13:57:35 CEST 2019


Hi!
> > Why 128?
> 
> Was just restoring it to what it was previously.
> 
> > Can't we rather multiply the buff.stx_blksize/512 by 16?
> 
> That would work for ext4, but should this be loosened further to give 
> some headroom in case some FS preallocates more? Or is it preferable to 
> keep the test as strict as possible and loosen it when/if failures happen?

That is hard to decide. I would go for the lowest limit that works for
everybody.

Also for me ext4 allocates only one block for the file no matter what I
do, something has to be tuned differently in your setup.

Isn't it just a difference in the block size and inode size?

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list