[LTP] [PATCH v2 1/3] lib: adding .arch field in tst_test structure

Petr Vorel pvorel@suse.cz
Tue Jun 18 07:51:19 CEST 2019


Hi Li,

> > > Testcases for specified arch should be limited on that only being
> > supported
> > > platform to run, we now create a function tst_on_arch to achieve this new
> > > feature in LTP library.  All you need to run a test on the expected arch
> > is
> > > to set the '.arch' string in the 'struct tst_test' to choose the required
> > > arch list. e.g. '.arch = "x86_64 i386"'.
> > Just one note, strings are error prone. I wonder if defining constants and
> > using
> > array would be too complicated for this use case.


> I thought about that array way, but it seems a bit complicted in using.
> Yes, strings are easy to involve typo but we can make a check in library.
OK, agree :).

> Thanks for review.

Kind regards,
Petr


More information about the ltp mailing list