[LTP] [PATCH v2 3/3] ima: Add overlay test

[Ignaz Forster]

Hi Petr,

thanks a lot for your continued work on the IMA / EVM tests and sorry 
for missing feedback - the mail got lost in my stack of TODO items.

Am 05.04.19 um 18:52 Uhr schrieb Petr Vorel:
> Should I check EVM enabled?

As these tests require an appropriately prepared machine anyway: How 
about printing a message whether only IMA or both IMA and EVM are 
enabled. These tests make sense in both cases, so I wouldn't block them 
on either setup.

> /sys/kernel/security/evm should be 1?

Yes, that should be enough to detect whether EVM is enabled.

> +test1()
> +{
> +	local file="foo1.txt"
> +
> +	tst_res TINFO "overwrite file in overlay"
> +	ROD echo lower \> $lower/$file
> +	EXPECT_PASS echo overlay \> $merged/$file

It seems the redirection / escaping is wrong here: the string "overlay" 
never ends up in the target file.

> +}
> +
> +test2()
> +{
> +	local file="foo2.txt"
> +
> +	tst_res TINFO "append file in overlay"
> +	ROD echo lower \> $lower/$file
> +	EXPECT_PASS echo overlay \>\> $merged/$file

Same here: "overlay" never ends up in the target file.

Ignaz