[LTP] [PATCH v2 1/2] OVL_MNT: add setup_overlay helper

[Murphy Zhou]

Hi Amir and Petr,

On Wed, May 15, 2019 at 08:20:57PM +0200, Petr Vorel wrote:
> Hi Amir, Murphy,
> 
> 
> > I liked your idea of create_overlay_dirs/mount_overlay better.
> > It is more flexible for future tests that may want to umount and
> > mount overlay several times and the setup of lower/upper files
> > could be very different in future tests, not limited to just creating
> > files (maybe symlinks, xattr).
> > The experience from xfstests overlay tests suggests that the
> > create_overlay_dirs/mount_overlay helpers are a good model to follow.
> 
> Thanks for ideas, agree with it.
> 
> Other thing is to have const char *file, const int lineno as first parameters
> for mount_overlay_() and create mount_overlay() and SAFE_MOUNT_OVERLAY() as macros,
> which would use it. See tst_mkfs{_,}() as examples.

Very good suggests! I'll digging into it.

Thanks,
M
> 
> > Thanks,
> > Amir.
> 
> Kind regards,
> Petr