[LTP] [RFC PATCH 0/1] Fix return value checks for posix apis

[Cyril Hrubis]

Hi!
> This is an RFC patch to demonstrate that most of the pthread_* calls
> in the open_posix_testsuite seem to be doing the return value checks
> incorrectly. Most posix_* apis return positive errno on failure and 0 on
> success.

This is unfortunately common misconception, also I guess you meant
pthread_* APIs here.

> PATCH 1/1 demonstrates the fixes needed for pthread_sigmask/6-1 for
> example. This pattern is fairly widespread in open_posix_testsuite.
> 
> After going through the documentation in the project, I wasn't sure if I
> tested this correctly. After building, I tried the following
> 
> $ cd testcases/open_posix_testsuite
> $ ./bin/run_tesit.sh conformance/interfaces/pthread_sigmask pthread_sigmask_6-1.run-test
> 
> ...and that keeps running into test being skipped due to missing file.
> (I do have pthread_sigmask_6-1.run-test in place).

Actually I always just run the binary, so in this case doing
./pthread_sigmask_6-1.run-test should suffice.

> So, consider this build tested only for now. I'd love to know how we can
> test this and if we are still using the testsuite, then I am happy to
> fix rest of the places where its broken.

Sounds good.

-- 
Cyril Hrubis
chrubis@suse.cz