[LTP] [PATCH v3] syscalls/move_page12: Add new regression test

Cyril Hrubis chrubis@suse.cz
Tue May 21 15:47:52 CEST 2019


Hi!
> +		if (tcases[n].offline) {
> +			if (do_soft_offline(tcases[n].tpages) == EINVAL) {
> +				SAFE_KILL(cpid, SIGKILL);
> +				SAFE_WAITPID(cpid, &status, 0);
> +				SAFE_MUNMAP(addr, tcases[n].tpages * hpsz);
> +				tst_res(TFAIL,
					^
					Shouldn't this be TCONF instead?

> +					"madvise() didn't support "
> +					"MADV_SOFT_OFFLINE");
                                             ^
					 LKML coding style prefers not
					 to break up user visible
					 strings, so this string should
					 be on one line even if the line
					 is longer than 80 chars.

> +				return;
> +			}
> +		}

Other than that it looks good.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list