[LTP] [PATCH ltp 2/5] runtest: rename gf*** and rwtest{1..5} in lvm.part{1, 2} and scsi_debug.part1

Petr Vorel pvorel@suse.cz
Mon Sep 2 11:00:07 CEST 2019


Hi,

> Hi!
> > There are lots tests with duplicated name gf*** and rwtest0{1..5} in the
> > 3 runtest file but they are testing different fs. Rename them to
> > distingulish.

> > 1. Change gf*** to gf***_lvm/gf***_scsi
> > 2. Chagne rwtest** to rwtest{1..8}**_lvm/rwtest{1..8}**_scsi, which the
> >    code 1..8 is the code for the target filesystem

> I'm undecided on this one. On one hand I do not think that maintaining
> unique names across different runtest files is feasible.
+1
> On the other
> hand this case is probably fine since it's unlikely that we will change
> these files frequently.

> Does anybody have strong opinion on this?
Not really. At least adding "_lvm" is quite descriptive (unlike AD00{1..9} =>
ADA00{1..9} in 3/5 patch).

Kind regards,
Petr


More information about the ltp mailing list