[LTP] [PATCH] memcg_stress_test.sh: Respect LTP_TIMEOUT_MUL set by user

Petr Vorel pvorel@suse.cz
Thu Sep 12 17:28:20 CEST 2019


Hi,

> > @Petr and @Cristian, If I misunderstand anything, please correct me.

> my understanding was that:

> - we should already be able to set a non default per-test timeout using
>   the existing global LTP_TIMEOUT_MUL (and we are)

> - in this test we hardcoded such LTP_TIMEOUT_MUL to 7 because is the minimum sane
>   value for this test (less than 7 and it fails 100%)

> - we want to allow again the user to specify its own LTP_TIMEOUT_MUL if he wants
>   BUT also being able to enforce on a test by test basis a MINIMUM allowed value:
>   so we would define LTP_TIMEOUT_MUL_MIN=7 here, and then a user would be free to 
>   run LTP with a different global LTP_TIMEOUT_MUL but when running this test

>   + if LTP_TIMEOUT_MUL < LTP_TIMEOUT_MUL_MIN ===> use local LTP_TIMEOUT_MUL_MIN
>   + if LTP_TIMEOUT_MUL >= LTP_TIMEOUT_MUL_MIN  ===> use global LTP_TIMEOUT_MUL

LTP_TIMEOUT_MUL is only for user, LTP_TIMEOUT_MUL_MIN is only for library.
It's similar to way which is used in virt_lib.sh (VIRT_PERF_THRESHOLD_MIN).
See
https://patchwork.ozlabs.org/patch/1155460/

I'll probably sent this patch today although so you can base the work on it.
Is that ok?

Kind regards,
Petr

> This way you don't break specific tests' needs while allowing the user to global reduce
> run-time....now basically the user cannot enforce a higher timeout on this test
> using the global LTP_TIMEOUT_MUL even if it should be allowed to since this wouldn't
> break the test.

> ...unless I misunderstood too o_O :D


More information about the ltp mailing list