[LTP] [PATCH 3/3] net/if-mtu-change.sh: set LTP_TIMEOUT

Clemens Famulla-Conrad cfamullaconrad@suse.de
Fri Sep 13 12:00:12 CEST 2019


On Thu, 2019-09-12 at 22:13 +0200, Petr Vorel wrote:
> The default setup (100 * 5 seconds just for sleep) is longer than
> default timeout.
> 30 sec for each iteration should be more than enough as a default.
> 
> Fixes: fbea02ab5 ("lib/tst_test.sh: setup timeout per test run for
> the shell tests")
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  testcases/network/stress/interface/if-mtu-change.sh | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/testcases/network/stress/interface/if-mtu-change.sh
> b/testcases/network/stress/interface/if-mtu-change.sh
> index 30c013214..a1113f714 100755
> --- a/testcases/network/stress/interface/if-mtu-change.sh
> +++ b/testcases/network/stress/interface/if-mtu-change.sh
> @@ -1,6 +1,6 @@
>  #!/bin/sh
>  # SPDX-License-Identifier: GPL-2.0-or-later
> -# Copyright (c) 2017-2018 Petr Vorel <pvorel@suse.cz>
> +# Copyright (c) 2017-2019 Petr Vorel <pvorel@suse.cz>
>  # Copyright (c) 2015-2017 Oracle and/or its affiliates. All Rights
> Reserved.
>  # Copyright (c) International Business Machines  Corp., 2005
>  # Author: Mitsuru Chinen <mitch@jp.ibm.com>
> @@ -13,6 +13,8 @@ TST_CLEANUP="do_cleanup"
>  # The interval of the mtu change [second]
>  CHANGE_INTERVAL=${CHANGE_INTERVAL:-5}
>  
> +LTP_TIMEOUT=$(((CHANGE_INTERVAL + 30) * MTU_CHANGE_TIMES))

   ^
   TST_TIMEOUT

At least I would go with TST_ instead of LTP_ as the prefix TST_ means
for me Libray and LTP_ user. This apply to some other places of this
patchset.


> +
>  # The array of the value which MTU is changed into sequentially
>  # 552 - net.ipv4.route.min_pmtu
>  CHANGE_VALUES="784 1142 552 1500 552 1500 552 748 552 1142 1500"


More information about the ltp mailing list