[LTP] [PATCH v2 2/3] shell: Introduce TST_TIMEOUT variable

Li Wang liwang@redhat.com
Wed Sep 18 10:46:01 CEST 2019


Hi Petr,

On Wed, Sep 18, 2019 at 4:24 PM Petr Vorel <pvorel@suse.cz> wrote:

> ...
>
> > So, maybe that could be as a reason to disable float support for
> > $LTP_TIMEOUT_MUL?
>
> Maybe I'm missing something, therefore explaining the intent of the code.
> (int was handled in if tst_is_int "$LTP_TIMEOUT_MUL"; then):
>
I'm not blaming the int/float judgment, there is no problem. My concern is:

If the $LTP_TIMEOUT_MUL is float and awk command is missing, how things
will be going?

It will break at:
    tst_test_cmds awk
right?

Given that break on float number handling, why not declare only support
integer for $LTP_TIMEOUT_MUL?

I hope I explained clearly this time, haha ;-)

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20190918/a860ca1b/attachment-0001.htm>


More information about the ltp mailing list