[LTP] [PATCH 3/5] syscalls: semctl: Add new test to verify the _time_high fields

Viresh Kumar viresh.kumar@linaro.org
Fri May 22 09:12:58 CEST 2020


On 21-05-20, 16:26, Cyril Hrubis wrote:
> Hi!
> > > The _time_high fields must be reset by the kernel, add a test to verify
> > > that.
> > >
> > > Suggested-by: Arnd Bergmann <arnd@arndb.de>
> > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > 
> > Right, here you do need to copy the struct definitions since I forgot
> > to add a way to detect the presence in the kernel header files,
> > sorry about that.
> > 
> > Possibly you could just have a check in the Makefile that lets
> > skips the test if it fails to build because of old kernel headers?
> > Or maybe check LINUX_VERSION_CODE to see if the headers
> > are at least from linux-4.19?
> 
> We usually include autotools checks and fallback definitions in
> include/lapi.h in this case.

And that's what my patches are doing. They check for 

#ifndef HAVE_MSQID64_DS

and then only go define them.

We can't work with kernel versions due to possible backporting of the
patches to older kernels.

-- 
viresh


More information about the ltp mailing list