[LTP] [PATCH v2 2/5] fanotify: Handle supported features checks in setup()

Petr Vorel pvorel@suse.cz
Fri Nov 13 21:12:27 CET 2020


Hi Amir,

> > > +++ b/testcases/kernel/syscalls/fanotify/fanotify03.c
> > > @@ -212,28 +212,23 @@ static int setup_mark(unsigned int n)
> > >         char *const files[] = {fname, FILE_EXEC_PATH};

> > >         tst_res(TINFO, "Test #%d: %s", n, tc->tname);
> > > +
> > > +       if (support_exec_events != 0 && tc->mask & FAN_OPEN_EXEC_PERM) {
> > > +               tst_res(TCONF | TERRNO, "FAN_OPEN_EXEC_PERM not supported in kernel?");
> > > +               return -1;
> > > +       }
> > > +

> Please remove the comment above tcases[] definition:
> "Ensure to keep the first..."

> It is no longer needed after this change.
+1 (this one is easy).
FYI I've sent v3, but that does not address your comments
(just fixes failure).

I'll have look into your comments next week.

> Thanks,
> Amir.

Kind regards,
Petr


More information about the ltp mailing list