[LTP] 回复: [PATCH v2] cleanup: Unify the annotation style and remove Redundant code

[Xiao Yang]

On 3/17/21 7:34 PM, Petr Vorel wrote:
> Hi all,
>
>>> Hi Gongyi,
>>>> Change 'DESCRIPTION' to 'Description' and change 'ALGORITHM' to
>>>> 'Algorithm', and remove Redundant tst_reap_children since
>>>> tst_reap_children has been called in the test skeleton.
>>> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>> Hi Petr,
>> If we want to unify the format of 'Description' and 'Algorithm' in test, it seems redundant to do the conversion in testinfo.pl, right?
>> Can we use either of them(not both of them) because it is unnecessary to do the same thing twice.
> I'd keep both: this is for cleanup of old approach, conversion in testinfo.pl in
> case there is inconsistency in the future.
>
> But not a strong opinion about it, it's not that important.

Hi Petr,

Other than that, it looks good to me.

Acked-by: Xiao Yang <yangx.jy@cn.fujitsu.com>

Best Regards,

Xiao Yang

>
> Kind regards,
> Petr
>