[LTP] [PATCH v2 2/2] syscalls/mkdir09: rewrite in new LTP API

Li Wang liwang@redhat.com
Sat Feb 5 05:19:23 CET 2022


Jan Stancek <jstancek@redhat.com> wrote:


> +#include "tst_test.h"
> +#include "tst_safe_pthread.h"
>
> +#define MNTPOINT       "mntpoint"
>  #define MODE_RWX       07770
>


> +#define DIR_NAME       MNTPOINT "/X.%d"
> +#define DIR_NAME_GROUP MNTPOINT "/X.%d.%d"
> +#define NCHILD         3
>


>  static int child_groups = 2;
> -static int test_time = 5;
> +static int test_time = 1;
>  static int nfiles = 5;
>

I think initialize 'nfiles' to 10 will be better.

As we can see the test3 starts from 'j=2' and only creates
one directory for testing, but the comment says many
directories. Also, it will test more dirs in test1 and test2.

Otherwise, this patch looks pretty good.
Reviewed-by: Li Wang <liwang@redhat.com>


-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20220205/9197e9cc/attachment.htm>


More information about the ltp mailing list