[LTP] [PATCH] getrusage03: skip on small RAM system

Li Wang liwang@redhat.com
Mon Feb 7 11:08:47 CET 2022


On Mon, Feb 7, 2022 at 3:41 PM Petr Vorel <pvorel@suse.cz> wrote:

> Hi Li,
>
> > Notes:
> >     Ps. I also think we might need .min_mem_[avai|total] field but
> >         not sure if it is really necessary to add that.
> Is it just a single test? Than maybe not worth of it, but generally I'm for
>

By now I only see sporadic tests have this requirement.
(hugeshmat04.c, swapping01.c, getrusage03.c)

> adding tags like this into the library - it encapsulates code and gives us
> a
> documentation in docparse.
>

Agree, maybe just holding as a future plan for adding that.



> ...
> > +static void setup(void)
> > +{
> > +     long long mem_avail = tst_available_mem();
> > +
> > +     if (mem_avail < 512L*1024)
> > +             tst_brk(TCONF, "Needed > 512MB availabe, only have: %ld
> kB", mem_avail);
> typo: s/availabe/available/
>

Thanks.



>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
> Thanks!
>
> Kind regards,
> Petr
>
>

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20220207/2cced592/attachment-0001.htm>


More information about the ltp mailing list