[LTP] [PATCH] test_macros: TST_EXP_EXPR() add auto stringification

Petr Vorel pvorel@suse.cz
Fri Feb 18 11:31:31 CET 2022


Hi Cyril,

> Hi!
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > Good idea.

> It occured to me that this is probably not the best result though, since
> in the case of the failure it does not print the expected and actual
> value. So maybe it would be better to add TST_EXP_EQ() macro instead. I
> will send a patch later on.

I wonder can't we have both - print stringified parameters and also their
values? Would it be too confusing?

> > BTW I'm thinking to add some comments to "top level" macros.
> > because it's getting hard to read these macros.

> Well yes, it's getting a bit hard to read indeed.
I mean it's good to have documented in our wiki. But even we document all
macros most of us will endup reading the header, thus why useful to document
at least end user ("top level") macros.

Kind regards,
Petr


More information about the ltp mailing list