[LTP] [PATCH v2] Fix mountns01/02/03/04 final umounts using more peculiar dir names

Cyril Hrubis chrubis@suse.cz
Wed Jun 22 10:35:22 CEST 2022


Hi!
> >> --- a/testcases/kernel/containers/mountns/mountns.h
> >> +++ b/testcases/kernel/containers/mountns/mountns.h
> >> @@ -10,8 +10,8 @@
> >>  #include "tst_test.h"
> >>  #include "lapi/namespaces_constants.h"
> >>  
> >> -#define DIRA "A"
> >> -#define DIRB "B"
> >> +#define DIRA "__DIR_A"
> >> +#define DIRB "__DIR_B"
> > This is the only non-comment change. How does renaming the directories
> > change anything? Am I missing something?
> Nevermind, now after I read the v1-thread, I get it..

We tend to prefix globally visible objects with LTP_ in order to make
them unique enough and that makes them clearly recognizable as being
created by LTP as well. So maybe we should put the LTP string somewhere
in the names too.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list