[LTP] [PATCH v1] Rewrite the gethostname01 using new LTP API
Cyril Hrubis
chrubis@suse.cz
Mon Aug 7 11:32:41 CEST 2023
Hi!
> .../syscalls/gethostname/gethostname01.c | 173 +++---------------
> 1 file changed, 23 insertions(+), 150 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/gethostname/gethostname01.c b/testcases/kernel/syscalls/gethostname/gethostname01.c
> index a7cb5417f..1c07c46b7 100644
> --- a/testcases/kernel/syscalls/gethostname/gethostname01.c
> +++ b/testcases/kernel/syscalls/gethostname/gethostname01.c
> @@ -1,161 +1,34 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /*
> - * Copyright (c) 2000 Silicon Graphics, Inc. All Rights Reserved.
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of version 2 of the GNU General Public License as
> - * published by the Free Software Foundation.
This is GPL-2.0 only, please fix the SPDX
> - * This program is distributed in the hope that it would be useful, but
> - * WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> - *
> - * Further, this software is distributed without any warranty that it is
> - * free of the rightful claim of any third person regarding infringement
> - * or the like. Any license provided herein, whether implied or
> - * otherwise, applies only to this software file. Patent licenses, if
> - * any, provided herein do not apply to combinations of this program with
> - * other software, or any other product whatsoever.
> - *
> - * You should have received a copy of the GNU General Public License along
> - * with this program; if not, write the Free Software Foundation, Inc.,
> - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> - *
> - * Contact information: Silicon Graphics, Inc., 1600 Amphitheatre Pkwy,
> - * Mountain View, CA 94043, or:
> - *
> - * http://www.sgi.com
> - *
> - * For further information regarding this notice, see:
> - *
> - * http://oss.sgi.com/projects/GenInfo/NoticeExplan/
> - *
> + * Copyright (c) International Business Machines Corp., 2001
> + * 07/2001 Ported by Wayne Boyer
> + * Copyright (c) Linux Test Project, 2002-2015
> + * Copyright (c) 2023 SUSE LLC Avinesh Kumar <avinesh.kumar@suse.com>
And this is completely wrong, I suppose you copy & pasted the copyrights
and haven't checked if they are correct...
> */
> -/* $Id: gethostname01.c,v 1.6 2009/10/26 14:55:47 subrata_modak Exp $ */
> -/**********************************************************
> - *
> - * OS Test - Silicon Graphics, Inc.
> - *
> - * TEST IDENTIFIER : gethostname01
> - *
> - * EXECUTED BY : anyone
> - *
> - * TEST TITLE : Basic test for gethostname(2)
> - *
> - * PARENT DOCUMENT : usctpl01
> - *
> - * TEST CASE TOTAL : 1
> - *
> - * WALL CLOCK TIME : 1
> - *
> - * CPU TYPES : ALL
> - *
> - * AUTHOR : William Roske
> - *
> - * CO-PILOT : Dave Fenner
> - *
> - * DATE STARTED : 03/30/92
> - *
> - * INITIAL RELEASE : UNICOS 7.0
> - *
> - * TEST CASES
> - *
> - * 1.) gethostname(2) returns...(See Description)
> - *
> - * INPUT SPECIFICATIONS
> - * The standard options for system call tests are accepted.
> - * (See the parse_opts(3) man page).
> - *
> - * DURATION
> - * Terminates - with frequency and infinite modes.
> - *
> - * SIGNALS
> - * Uses SIGUSR1 to pause before test if option set.
> - * (See the parse_opts(3) man page).
> - *
> - * RESOURCES
> - * None
> - *
> - * ENVIRONMENTAL NEEDS
> - * No run-time environmental needs.
> - *
> - * SPECIAL PROCEDURAL REQUIREMENTS
> - * None
> - *
> - * INTERCASE DEPENDENCIES
> - * None
> - *
> - * DETAILED DESCRIPTION
> - * This is a Phase I test for the gethostname(2) system call. It is intended
> - * to provide a limited exposure of the system call, for now. It
> - * should/will be extended when full functional tests are written for
> - * gethostname(2).
> - *
> - * Setup:
> - * Setup signal handling.
> - * Pause for SIGUSR1 if option specified.
> - *
> - * Test:
> - * Loop if the proper options are given.
> - * Execute system call
> - * Check return code, if system call failed (return=-1)
> - * Log the errno and Issue a FAIL message.
> - * Otherwise, Issue a PASS message.
> - *
> - * Cleanup:
> - * Print errno log and/or timing stats if options given
> - *
> - *
> - *#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#**/
> -
> -#include <errno.h>
> -#include <signal.h>
> -#include <string.h>
> -
> -#include "test.h"
>
> -void setup();
> -void cleanup();
> +/*
> + * [Description]
> + *
> + * This is a Phase I test for the gethostname(2) system call. It is intended
> + * to provide a limited exposure of the system call, for now. It
> + * should/will be extended when full functional tests are written for
> + * gethostname(2).
^
Too many spaces here, I suppose that this will render wrong in
the generated docs.
Also can we please write something more sensible here? Something along the
lines of "Checks that gethostname() succeeds."
> + */
>
> -char *TCID = "gethostname01";
> -int TST_TOTAL = 1;
> +#include "tst_test.h"
> +#include <stdlib.h>
>
> -int main(int ac, char **av)
> +static void run(void)
> {
> - int lc;
> + char hname[100];
> + int ret = gethostname(hname, sizeof(hname));
>
> - char hname[100]; /* host name */
> + if (!ret)
> + tst_res(TPASS, "gethostname %s", hname)
There is no tst_res(TFAIL, ...) if the call fails.
Also we do have a nice TST_EXP_PASS() macros now that should be used in
this case.
> - tst_parse_opts(ac, av, NULL, NULL);
> -
> - setup();
> -
> - for (lc = 0; TEST_LOOPING(lc); lc++) {
> -
> - tst_count = 0;
> -
> - TEST(gethostname(hname, sizeof(hname)));
> -
> - if (TEST_RETURN == -1) {
> - tst_resm(TFAIL | TTERRNO, "gethostname failed");
> - continue; /* next loop for MTKERNEL */
> - }
> -
> - tst_resm(TPASS, "gethostname returned %ld",
> - TEST_RETURN);
> - }
> -
> - cleanup();
> - tst_exit();
> }
>
> -void setup(void)
> -{
> -
> - tst_sig(NOFORK, DEF_HANDLER, cleanup);
> -
> - TEST_PAUSE;
> -}
>
> -void cleanup(void)
> -{
> -}
> +static struct tst_test test = {
> + .test_all = run
> +};
> --
> 2.41.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
More information about the ltp
mailing list