[LTP] [PATCH 1/2] syscalls/faccessat201: Add new testcase

Cyril Hrubis chrubis@suse.cz
Fri Aug 11 13:59:47 CEST 2023


Hi!
> Why do we allocate anything here when we replace the pointers in the
> test setup anyways?
> 
> If anything it would make sense to allocate the buffers in the test
> setup instead of using static strings there. Also filepath[x] way less
> readable than actually giving the variables proper names such as
> abs_path.

And it turns out that tst_strdup() was already there, however I've send
a patch to add .str member to the tst_buffers structure as well as
tst_aprintf(). The usage should be clear from the few tests I've
converted to use the new API.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list