[LTP] [PATCH 2/2] syscalls/renameat2: Remove renameat2 fallback definition

Xiao Yang yangx.jy@fujitsu.com
Fri Aug 25 11:25:08 CEST 2023


Hi Xu,

The same comment as I said on renameat01.c.
Reviewed-by: Xiao Yang <yangx.jy@fujitsu.com>

Best Regards,
Xiao Yang

On 2023/8/24 19:10, Yang Xu wrote:
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
>   .../kernel/syscalls/renameat2/renameat2.h     | 35 -------------------
>   .../kernel/syscalls/renameat2/renameat201.c   |  2 +-
>   .../kernel/syscalls/renameat2/renameat202.c   |  2 +-
>   3 files changed, 2 insertions(+), 37 deletions(-)
>   delete mode 100644 testcases/kernel/syscalls/renameat2/renameat2.h
> 
> diff --git a/testcases/kernel/syscalls/renameat2/renameat2.h b/testcases/kernel/syscalls/renameat2/renameat2.h
> deleted file mode 100644
> index c4688ed53..000000000
> --- a/testcases/kernel/syscalls/renameat2/renameat2.h
> +++ /dev/null
> @@ -1,35 +0,0 @@
> -/*
> - * Copyright (c) 2015 Cedric Hnyda <chnyda@suse.com>
> - *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License as
> - * published by the Free Software Foundation; either version 2 of
> - * the License, or (at your option) any later version.
> - *
> - * This program is distributed in the hope that it would be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write the Free Software Foundation,
> - * Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
> - */
> -
> -#ifndef RENAMEAT2_H
> -#define RENAMEAT2_H
> -
> -#include <sys/types.h>
> -#include "config.h"
> -#include "lapi/syscalls.h"
> -
> -#if !defined(HAVE_RENAMEAT2)
> -int renameat2(int olddirfd, const char *oldpath, int newdirfd,
> -				const char *newpath, unsigned int flags)
> -{
> -	return tst_syscall(__NR_renameat2, olddirfd, oldpath, newdirfd,
> -						newpath, flags);
> -}
> -#endif
> -
> -#endif /* RENAMEAT2_H */
> diff --git a/testcases/kernel/syscalls/renameat2/renameat201.c b/testcases/kernel/syscalls/renameat2/renameat201.c
> index 9832b1cdb..ff1747b8d 100644
> --- a/testcases/kernel/syscalls/renameat2/renameat201.c
> +++ b/testcases/kernel/syscalls/renameat2/renameat201.c
> @@ -37,7 +37,7 @@
>   #include "test.h"
>   #include "safe_macros.h"
>   #include "lapi/fcntl.h"
> -#include "renameat2.h"
> +#include <errno.h>
>   
>   #define TEST_DIR "test_dir/"
>   #define TEST_DIR2 "test_dir2/"
> diff --git a/testcases/kernel/syscalls/renameat2/renameat202.c b/testcases/kernel/syscalls/renameat2/renameat202.c
> index 0c1457022..ef3df3e91 100644
> --- a/testcases/kernel/syscalls/renameat2/renameat202.c
> +++ b/testcases/kernel/syscalls/renameat2/renameat202.c
> @@ -26,7 +26,7 @@
>   #include "test.h"
>   #include "safe_macros.h"
>   #include "lapi/fcntl.h"
> -#include "renameat2.h"
> +#include <errno.h>
>   
>   #define TEST_DIR "test_dir/"
>   #define TEST_DIR2 "test_dir2/"


More information about the ltp mailing list