[LTP] [PATCH 2/2] hugeshmctl03: Mark struct tcase as static

Yang Xu (Fujitsu) xuyang2018.jy@fujitsu.com
Fri Aug 25 13:31:15 CEST 2023


Hi, Xiao Yang
> Hi Xu,
>
> The same comment as I said on hugeshmctl01.
> Reviewed-by: Xiao Yang <yangx.jy@fujitsu.com>
>
> Best Regards,
> Xiao Yang
>

ok.I'll correct the subject.

Best Regards,
Yang Xu


> On 2023/8/24 19:11, Yang Xu wrote:
>> To follow LTP conventions.
>>
>> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
>> ---
>>   testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl03.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl03.c 
>> b/testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl03.c
>> index 21ec6bf78..61e9704bb 100644
>> --- a/testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl03.c
>> +++ b/testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl03.c
>> @@ -44,7 +44,7 @@ static struct shmid_ds buf;
>>   static uid_t ltp_uid;
>>   static char *ltp_user = "nobody";
>>   -struct tcase {
>> +static struct tcase {
>>       int *shmid;
>>       int cmd;
>>       struct shmid_ds *sbuf;
>> @@ -97,7 +97,7 @@ static void do_child(void)
>>       }
>>   }
>>   -void setup(void)
>> +static void setup(void)
>>   {
>>       long hpage_size;
>>   @@ -118,7 +118,7 @@ void setup(void)
>>       ltp_uid = getuserid(ltp_user);
>>   }
>>   -void cleanup(void)
>> +static void cleanup(void)
>>   {
>>       rm_shm(shm_id_1);
>>   }


More information about the ltp mailing list