[LTP] [PATCH v4] Add epoll_wait05 test

Andrea Cervesato andrea.cervesato@suse.com
Tue Aug 29 09:52:15 CEST 2023


Hi,

On 8/29/23 09:25, Cyril Hrubis wrote:
> Hi!
>> This test verifies that epoll receives EPOLLRDHUP event when we hang
>> a reading half-socket we are polling on.
>>
>> Implements: https://github.com/linux-test-project/ltp/issues/860
>> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> ...
>
>> +/*\
>> + * [Description]
>> + *
>> + * Verify that epoll receives EPOLLRDHUP event when we hang a reading
>> + * half-socket we are polling on.
>> + *
>> + * As reference please check https://lwn.net/Articles/864947/
> I'm a bit confused here, the test itself looks good, but it references
> an article and a kernel commit that changed how polling on _pipe_ works.
> The kernel change literally changes only pipe_write() in fs/pipe.c and
> this test actually tests inet sockets.
>
> I guess that the confusion is caused by the fact that the github issue
> referenced the lwn.net article as a reason why we need more epoll
> coverage, but these tests are not directly related to that commit at
> all.
>
If patch is fine, is it possible to push it removing the reference?

Thanks,
Andrea




More information about the ltp mailing list