[LTP] [PATCH v3 1/3] lib/tests: Add test for testing tst_res() flags

Petr Vorel pvorel@suse.cz
Thu Dec 14 13:19:35 CET 2023


> Hi!
> > > Maybe it would make sense the loop over the flags here instead, so that
> > > we don't have to produce second TPASS message.

> > I'm not sure if I follow you. I wanted to use the flag in tst_res(),
> > but for these two there would be tst_brk(TBROK) due missing result.

> I mean that if we put TBROK last in the array we can do:

> 	for (i = 0; i < ARRAY_SIZE(...); i++)
> 		tst_res(....);

Yeah, I realized that later (it was too late already when I wrote the question).
My motivation was that extra TPASS also test functionality, we test, that TINFO
and TDEBUG are not results. But this is probably not important, thus I'll just
loop over array. And sure, I'll put TBROK to the end.

Kind regards,
Petr

> I.e. loop over all the flags in a single call of the function, which
> would mean that we do not have to add artificial TPASS at the end.



More information about the ltp mailing list