[LTP] [PATCH 1/1] net: tst_netload_compare(): Ignore performance failures

Petr Vorel pvorel@suse.cz
Tue Dec 19 13:49:42 CET 2023


Hi all,

> Performance failures in tests which use tst_netload_compare() (tests in
> runtest/net.features) can hide a real error (e.g. test fails due missing
> required kernel module). Best solution would be to have feature tests
> (likely written in C API) and performance tests (the current ones).

> But until it happens, just disable performance failure by default,
> print TINFO message instead unless TST_NET_FEATURES_TEST_PERFORMANCE=1
> environment variable is set.

NOTE: why is this enabled by default? IMHO it's more important to have feature
tests than performance tests often failing and thus hiding feature test.
Even introducing some LTP_TIMEOUT_MUL like variable would not help in case SUT
performance differs (sometimes SUTs are ok, other time slow due QEMU host which
runs SUTs is overbooked).

Kind regards,
Petr


More information about the ltp mailing list