[LTP] [PATCH v2 1/2] syscalls/geteuid01: Convert into new api

Petr Vorel pvorel@suse.cz
Tue Jul 18 12:02:05 CEST 2023


Hi Xu,

> Hi Petr

> > Hi Xu,

> >> + * Copyright (c) Linux Test Project, 2003-2023
> >> + * AUTHOR: William Roske, Dave Fenne
> > Very very nit: s/AUTHOR/Author/

> > Also, in the subject in both commits: s/api/API/

> > Reviewed-by: Petr Vorel <pvorel@suse.cz>

> Thanks for your review.

> I merged this patch set and modified getuid01 to origin gpl-2.0-only.

> But  It seems all of uid/gid case miss to use COMPAT_TST_16_H:= 1 in 
> Makefile except syscalls/setuid.

> I search the history, it seems related to  a bugfix[1] when 
> touch/modify/create fiel in syscall/utils.

> [1]https://github.com/linux-test-project/ltp/commit/631d16671d876524588320ee71fd23fe22750307

Good point. I send a patch which switches the logic (old tests have variable):

https://patchwork.ozlabs.org/project/ltp/patch/20230718100050.1162482-1-pvorel@suse.cz/

Kind regards,
Petr

> Best Regards
> Yang Xu

> > Kind regards,
> > Petr


More information about the ltp mailing list