[LTP] [PATCH 2/3] tst_netdevice: Add helper functions for qdisc and filter management

Petr Vorel pvorel@suse.cz
Fri Jul 28 14:09:12 CEST 2023


Hi Martin,

...
nit: missing comment here, but the meaning is obvious. Also
NETDEV_REMOVE_TRAFFIC_CLASS() (and tst_netdev_remove_traffic_filter()) look to
be unused, but I guess you expect to use it in another reproducer.
> +int tst_netdev_remove_traffic_class(const char *file, const int lineno,
> +	const char *ifname, unsigned int parent, unsigned int handle,
> +	const char *qd_kind);
> +#define NETDEV_REMOVE_TRAFFIC_CLASS(ifname, parent, handle, qd_kind) \
> +	tst_netdev_remove_traffic_class(__FILE__, __LINE__, (ifname), \
> +		(parent), (handle), (qd_kind))

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr


More information about the ltp mailing list